Add focus trap, to disallow tabbing outside the modal#408
Merged
RobbieTheWagner merged 3 commits intomasterfrom Jun 21, 2019
Merged
Add focus trap, to disallow tabbing outside the modal#408RobbieTheWagner merged 3 commits intomasterfrom
RobbieTheWagner merged 3 commits intomasterfrom
Conversation
Member
Author
|
@chuckcarpenter do you think we should trap the keyboard for both modal and non-modal or only modal? |
chuckcarpenter
approved these changes
Jun 21, 2019
Member
chuckcarpenter
left a comment
chuckcarpenter
left a comment
There was a problem hiding this comment.
Hadn't considered this, but makes sense to me.
RobbieTheWagner
force-pushed
the
trap-focus
branch
from
eca4369 to
74bb9d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This keyboard trap implementation was taken from https://bitsofco.de/accessible-modal-dialog/ and is related to #198