Fix for the wrong type definition of StepOptions.scrollTo#494
Merged
RobbieTheWagner merged 1 commit intoshipshapecode:masterfrom Aug 9, 2019
Merged
Fix for the wrong type definition of StepOptions.scrollTo#494RobbieTheWagner merged 1 commit intoshipshapecode:masterfrom
RobbieTheWagner merged 1 commit intoshipshapecode:masterfrom
Conversation
| * Should the element be scrolled to when this step is shown? | ||
| */ | ||
| scrollTo?: boolean; | ||
| scrollTo?: boolean | ScrollIntoViewOptions; |
Member
There was a problem hiding this comment.
ScrollIntoViewOptions is not defined. We'll need to add it as well, won't we?
Member
There was a problem hiding this comment.
Looks like this is built into TS, so should be okay.
RobbieTheWagner
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple fix for the wrong type definition of StepOptions.scrollTo property
Fixes #490