fix(SalesOrdersExport): Paging Bug#53
Merged
justin-robertson-git merged 4 commits intomasterfrom Apr 22, 2025
Merged
Conversation
If the query returns nothing we shouldn't throw an error about page sizing, we should just return an empty array.
Updated Change Log & Composer Version
dburch-shipstation
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sales Orders Export Paging Bug
When the request comes in for a page that doesn't exist or if there are no orders in the system that match the criteria we should just immediately return a successful response with an empty orders array.