Skip to content

PHP 8.4 compatibility updates#58

Merged
justin-robertson-git merged 2 commits intoshipstation:masterfrom
ckd:master
Aug 22, 2025
Merged

PHP 8.4 compatibility updates#58
justin-robertson-git merged 2 commits intoshipstation:masterfrom
ckd:master

Conversation

@ckd
Copy link
Copy Markdown
Contributor

@ckd ckd commented Jun 2, 2025

PHP 8.4: make implicitly-nullable param types explicit

  • Replace signatures like Type $x = null with ?Type $x = null (or Type|null)
  • Eliminates PHP 8.4 deprecations; prepares for PHP 9
  • No behavioral changes; note potential override adjustments for extenders

@ckd ckd requested a review from a team as a code owner June 2, 2025 15:38
@ckd
Copy link
Copy Markdown
Contributor Author

ckd commented Aug 21, 2025

@justin-robertson-git hey, can you review this PR?

@CalzaFino
Copy link
Copy Markdown

Any update on the timing for the release of this update?

@justin-robertson-git
Copy link
Copy Markdown
Contributor

@ckd @CalzaFino this looks good, I will bump the versions / merge / start the publishing process tomorrow when I get into the office.

@justin-robertson-git justin-robertson-git merged commit dd01b95 into shipstation:master Aug 22, 2025
@justin-robertson-git
Copy link
Copy Markdown
Contributor

@ckd @CalzaFino the update has been submitted to Adobe for review, I will let you all know when it is live.

@ckd
Copy link
Copy Markdown
Contributor Author

ckd commented Aug 22, 2025

Thanks @justin-robertson-git, I appreciate it!

@justin-robertson-git
Copy link
Copy Markdown
Contributor

@ckd @CalzaFino https://commercemarketplace.adobe.com/auctane-api.html#product.info.details.release_notes It looks like the changes are now live. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants