Skip to content

feature: warning users when their export_presets.cfg is set to "legacy" build mode #128

@madebydavid

Description

@madebydavid

Background

The default export_presets.cfg file which is created by Godot has the build type set to legacy

This means that when the default export_presets.cfg file is present, shipthis will build the game as APK instead of AAB and APK. Unless the game is built as AAB the user will not be able to upload this to Google Play

Options

  • Ignore the export_presets.cfg and only output AAB with shipthis
  • Warn the user and give them the option to change it easily (e.g. edit the export_presets.cfg file for them after confirming)

I do not think we should ignore the export_presets.cfg - this could break things for existing users and there is still a use case for generating an APK via the legacy build method. I think it would be better if we warn the user and edit the config for them (after confirming)

Proposed changes

  • Adapt the android wizard to show a warning
    • This could be part of the "Create Initial Build" step
    • "Your export config is not set to output an AAB file - this means you will not be able to upload to Google Play. Would you like us to change this?"
    • Need to find a way to cleanly edit the export config file locally
  • Show a warning when running shipthis game ship
    • Since the logs are hidden by default - this could be shown below the progress bar - see the mockup below
  • Show a warning when running shipthis game ship --platform android --follow
    • This could be done in the local log messages which are shown before the build server output
Image

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions