Skip to content

Conversation

@madebydavid
Copy link
Member

@madebydavid madebydavid commented Nov 3, 2025

Description

Adding a --gameEngineVersion flag to the shipthis game ship command which sets that value for only the current build(s). If this flag is not present then the value from the shipthis game details command is used.

This is to resolve #21 - it will make it easier to run tests on different versions of Godot and so should make development of shipthis easier too.

What's changed

  • Backend and agent changes are not included here.
  • Extended the ShipGameFlags type and extended the options passed when starting jobs

@madebydavid madebydavid changed the title Adding gameEngineVersion to flags and job options feature: adding --gameEngineVersion flag to shipthis game ship to override the Godot version for the current build(s) Nov 3, 2025
@madebydavid
Copy link
Member Author

madebydavid commented Nov 3, 2025

Documentation will be needed for this, ideally:

  • update the md file for the ship command to include the new help output
  • update the same file to include some notes about using this flag

@madebydavid
Copy link
Member Author

docs done, ready for review

@madebydavid madebydavid marked this pull request as ready for review November 3, 2025 13:31
@madebydavid madebydavid requested a review from jamiel November 3, 2025 13:32
@madebydavid madebydavid marked this pull request as draft November 4, 2025 13:30
@madebydavid
Copy link
Member Author

I did some testing and found the whole project was still serialized in the config file. Made a small change to resolve this.

I have tested:

  • shipthis game create
  • shipthis game wizard ios
  • shipthis game wizard android
  • shipthis game ship
  • shipthis game details

@madebydavid madebydavid marked this pull request as ready for review November 4, 2025 15:07
@madebydavid madebydavid merged commit db2d2f1 into main Nov 4, 2025
@madebydavid madebydavid deleted the 21-feature-allow-setting-gameengineversion-when-running-shipthis-game-ship branch November 4, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Allow setting gameEngineVersion when running shipthis game ship

3 participants