Skip to content

Conversation

@madebydavid
Copy link
Member

@madebydavid madebydavid commented Nov 16, 2025

Description

In order to implement #116 (liquid glass icons) we have made two changes:

  • Added an extra field to the game details liquidGlassIconPath which when set will apply the specified .icon folder to the xcode project when it is built on the shipthis build servers
  • Added a util command to apply a given liquid glass icon to a given xcode project

What's changed

  • Type changes
  • Changes to the game details command
  • Added new utils topic
  • Added glass command to utils topic
  • Added docs for glass command

@madebydavid madebydavid force-pushed the 116-feat-add-support-for-liquid-glass-icons-which-will-be-applied-to-the-xcode-project-after-export branch from 2a61b39 to c200f0d Compare November 18, 2025 11:37
@madebydavid madebydavid changed the title WIP: Allow setting liquid glass icon path feature: ability to specify a liquid glass icon to be applied to the cloud-built game or to a local xcode project Nov 24, 2025
@madebydavid madebydavid marked this pull request as ready for review November 24, 2025 16:41
@madebydavid madebydavid requested a review from Copilot November 24, 2025 16:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for Liquid Glass icons in ShipThis by introducing a new utility command to apply .icon folders to local Xcode projects and adding a field to track the icon path in game details for cloud builds.

Key Changes:

  • Added liquidGlassIconPath field to ProjectDetails type for storing icon paths
  • Implemented util glass command to apply Liquid Glass icons to local Xcode projects
  • Added flag and UI display for managing Liquid Glass icon paths in game details

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/types/api.ts Added optional liquidGlassIconPath field to ProjectDetails interface
src/commands/util/glass.ts New command implementation for applying Liquid Glass icons to Xcode projects
src/commands/game/details.tsx Added support for setting and displaying liquidGlassIconPath in game details
src/baseCommands/index.ts Added liquidGlassIconPath flag to DetailsFlags
package.json Added xcode nightly dependency and exported glass command module
package-lock.json Lock file updates for xcode package and its dependencies
docs/util/glass.md Documentation for the new util glass command
docs/util.md New documentation topic page for util commands

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

madebydavid and others added 2 commits November 25, 2025 12:06
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@madebydavid
Copy link
Member Author

Will need to deploy agent changes to the prod environment before merging

@madebydavid
Copy link
Member Author

this should be ready to go

@madebydavid madebydavid merged commit 2980bc2 into main Nov 27, 2025
@madebydavid madebydavid deleted the 116-feat-add-support-for-liquid-glass-icons-which-will-be-applied-to-the-xcode-project-after-export branch November 27, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add support for liquid glass icons which will be applied to the xcode project after export

2 participants