-
Notifications
You must be signed in to change notification settings - Fork 1
feature: ability to specify a liquid glass icon to be applied to the cloud-built game or to a local xcode project #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2a61b39 to
c200f0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for Liquid Glass icons in ShipThis by introducing a new utility command to apply .icon folders to local Xcode projects and adding a field to track the icon path in game details for cloud builds.
Key Changes:
- Added
liquidGlassIconPathfield toProjectDetailstype for storing icon paths - Implemented
util glasscommand to apply Liquid Glass icons to local Xcode projects - Added flag and UI display for managing Liquid Glass icon paths in game details
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/types/api.ts |
Added optional liquidGlassIconPath field to ProjectDetails interface |
src/commands/util/glass.ts |
New command implementation for applying Liquid Glass icons to Xcode projects |
src/commands/game/details.tsx |
Added support for setting and displaying liquidGlassIconPath in game details |
src/baseCommands/index.ts |
Added liquidGlassIconPath flag to DetailsFlags |
package.json |
Added xcode nightly dependency and exported glass command module |
package-lock.json |
Lock file updates for xcode package and its dependencies |
docs/util/glass.md |
Documentation for the new util glass command |
docs/util.md |
New documentation topic page for util commands |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Will need to deploy agent changes to the prod environment before merging |
|
this should be ready to go |
Description
In order to implement #116 (liquid glass icons) we have made two changes:
liquidGlassIconPathwhich when set will apply the specified.iconfolder to the xcode project when it is built on the shipthis build serversWhat's changed