-
Notifications
You must be signed in to change notification settings - Fork 1
Prompt for Google Org policy change in wizard if Service Account Key creation is disabled #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tested on 80x24 https://asciinema.org/a/HWIWlSP2ntqb8lZsHm6MrdrTl Kazam_screencast_00019.webm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds automatic detection and prompting for Google Organization policy changes when Service Account Key creation is disabled in the wizard interface. It enhances the user experience by providing a guided workflow to handle required policy changes.
- Expanded the
CreateServiceAccountKeycomponent to detect policy change requirements and guide users through the process - Added new hook
useUpdateGoogleOrgPolicyfor managing organization policy mutations - Updated type definitions to properly handle date fields and added new markdown template for policy guidance
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/utils/query/useUpdateGoogleOrgPolicy.ts |
New hook for handling Google organization policy enforcement/revocation mutations |
src/utils/query/index.ts |
Export the new policy update hook |
src/types/api.ts |
Updated orgCreatedAt field type from string to DateTime |
src/components/android/CreateServiceAccountKey/index.tsx |
Enhanced component with policy detection, user prompting, and guided workflow |
src/components/android/CreateServiceAccountKey/SetupStatusTable.tsx |
Removed unused status table component |
src/commands/game/android/apiKey/policy.tsx |
Changed boolean coercion from !! to Boolean() for consistency |
src/api/index.ts |
Added date casting for API responses containing orgCreatedAt |
assets/markdown/service-account-policy-wizard.md.ejs |
New markdown template for policy change guidance |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Summary
This is to resolve #69 - if we detect that a policy change is needed then we prompt the user
What's changed
CreateServiceAccountKeycomponent