feat: adding a --verbose flag to shipthis game ship
#84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
Member
Author
|
Documentation page for the ship command will need updating too |
Member
Author
|
Copilot is not having a good day |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a --verbose flag to the shipthis game ship command to allow users to control logging verbosity during the ship process.
- Added verbose flag to ship command and type definitions
- Modified logging behavior to only show detailed messages when verbose mode is enabled
- Updated documentation to include the new verbose flag
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/commands/game/ship.tsx | Adds verbose flag definition and example usage |
| src/types/index.ts | Adds verbose property to ShipGameFlags type |
| src/utils/query/useShip.ts | Implements verbose logging logic and passes flag to API |
| src/api/index.ts | Adds verbose property to StartJobsOptions type |
| docs/game/ship.md | Updates documentation with verbose flag usage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| }) | ||
|
|
||
| const tmpZipFile = `${process.cwd()}/shipthis-${uuid()}.zip` | ||
| log(`Creating zip file: ${tmpZipFile}`) |
There was a problem hiding this comment.
These two log statements are not controlled by the verbose flag, unlike other similar logging statements. Consider making these consistent by applying the verbose condition: verbose && log(...) to maintain uniform logging behavior.
Suggested change
| log(`Creating zip file: ${tmpZipFile}`) | |
| verbose && log(`Creating zip file: ${tmpZipFile}`) |
madebydavid
deleted the
83-feature-add-a---verbose-flag-to-shipthis-game-ship-which-is-passed-through-to-the-build-server
branch
madebydavid
changed the title
--verbose flag to shipthis game ship--verbose flag to shipthis game ship
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to resolve #83
What's changed
--verboseflag to the ship commandStartJobsOptionsuseShipshipthis game shipto include the flag