feat: Clarify and Simplify SHIP Lifecycle #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
kind/documentation
pull-request-size
bot
added
the
size/L
pull-request-size
bot
added
size/M
This change proposes to merge the `rejected` and `withdrawn` phases with a `declined` phase. This phase preserves the intent of a feature that the community decided to not implement. To communicate how the lifecycle works, a MermaidJS flowchart has been added, and the markdown content has been restructured to include sub-headers. The `replaced` state has also been updated to communicate that a specific feature has been deprecated or removed. Deprecations and removals require SHIP proposals to ensure the end community is well informed and has sufficient time to stop using the given functionality. Finally, this change also adds a requirement that `implementable` proposals should create corresponding feature tracker issues in GitHub, with sub-issues that identify specific tasks that implement the feature. Tracker issues broadcast to the community work that needs to be done and document the progress of a feature. These tracker issues also encourage contributions from new community members. Assisted-by: Cursor Signed-off-by: Adam Kaplan <adam.kaplan@redhat.com>
adambkaplan
force-pushed
the
ship-lifecycle-update
branch
from
286535d to
199022f
Compare
adambkaplan
changed the title
|
/approve |
Member
Author
|
/approve Self-approving |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, sayan-biswas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Member
Author
|
Considering' @sayan-biswas 's comment an "LGTM", merging by lazy consensus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change proposes to merge the
rejectedandwithdrawnphases with a
declinedphase. This phase preserves the intentof a feature that the community decided to not implement. To
communicate how the lifecycle works, a MermaidJS flowchart has
been added, and the markdown content has been restructured to
include sub-headers.
The
replacedstate has also been updated to communicate thata specific feature has been deprecated or removed. Deprecations
and removals require SHIP proposals to ensure the end community
is well informed and has sufficient time to stop using the given
functionality.
Finally, this change also adds a requirement that
implementableproposals should create corresponding feature tracker issues
in GitHub, with sub-issues that identify specific tasks that
implement the feature. Tracker issues broadcast to the community
work that needs to be done and document the progress of a feature.
These tracker issues also encourage contributions from new
community members.
/kind feature
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes