Update go dependencies for 0.19 release#283
Conversation
hasanawad94
changed the title
hasanawad94
changed the title
hasanawad94
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
hasanawad94
force-pushed
the
deps-v19
branch
11 times, most recently
from
9b65f96 to
ea16b83
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
| - name: Create KinD cluster | ||
| uses: helm/kind-action@v1 | ||
| with: | ||
| version: v0.31.0 |
There was a problem hiding this comment.
That looks risky. Without it, I guess it takes latest, but what if latest stops being compatible with the node image we are using ?
There was a problem hiding this comment.
I agree here. Version pinning also makes it easier to reproduce a particular CI run.
SaschaSchwarze0
added
kind/dependency-change
adambkaplan
left a comment
adambkaplan
left a comment
There was a problem hiding this comment.
/approve
Green-lighting this to go in. However @hasanawad94 please address the issue with the kind-action workflow change. Once that is addressed I think this PR is able to be merged.
| - name: Create KinD cluster | ||
| uses: helm/kind-action@v1 | ||
| with: | ||
| version: v0.31.0 |
There was a problem hiding this comment.
I agree here. Version pinning also makes it easier to reproduce a particular CI run.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@hasanawad94 please also include a release note in the PR description. |
Update Go version to 1.25.6 golint fix: golangci-lint v2 requires the version: "2" field in the config — without it, it refuses to run. gcr.io/kubebuilder/kube-rbac-proxy image was moved to a different registry based on: https://github.com/kubernetes-sigs/kubebuilder/blob/master/designs/discontinue_usage_of_kube_rbac_proxy.md#summary Use `ObjectTracker` as a workaround with the new `controller-runtime` update in controllers/shipwrightbuild_controller_test.go Signed-off-by: Hasan Awad <hasan.m.awad94@gmail.com>
openshift-ci
bot
added
release-note-none
release-note
and removed
release-note
release-note-none
labels
3 participants
Changes
ObjectTrackeras a workaround with the newcontroller-runtimeupdate in controllers/shipwrightbuild_controller_test.goUpdate go modules:
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes