fix: correct installation scripts URLs#223
Open
sgaist wants to merge 1 commit intoshipwright-io:mainfrom
Open
Conversation
The manifests comes from the release but the scripts from the sources. Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
openshift-ci
Bot
added
the
kind/documentation
pull-request-size
Bot
added
the
size/XS
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
4 tasks
|
As an alternative to running a bash script "from the internet", would it be possible to describe what exactly is required? Which secrets, secret names, namespaces, etc.? People might want to provide a "proper" certificate for their webhook... :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manifests comes from the release but the scripts from the sources.
Changes
Fix wrong scripts URLs added in #220
Related Issue
Part of #221
Type of PR
/kind documentation
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes