feat(go): Remove ANTLR/expr-lang query system #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Removes legacy ANTLR query parser and expr-lang evaluation system to prepare for callgraph-native Python DSL. ## Breaking Changes - Removed ANTLR query syntax and parser (antlr/ directory) - Removed expr-lang evaluation engine (graph/query.go) - Stubbed out query, ci, and scan commands (will be reimplemented with Python DSL) - Removed dependencies: antlr4-go/antlr/v4, expr-lang/expr ## Files Changed **Deleted:** - antlr/* (13 files, ~200KB of generated code) - graph/query.go, graph/query_test.go - cmd/ci_test.go, cmd/scan_test.go **Modified:** - cmd/query.go, cmd/ci.go, cmd/scan.go (stubbed for Python DSL) - go.mod (removed ANTLR/expr-lang dependencies) - graph/parser_python_test.go (removed ANTLR query integration test) - main_test.go (updated expected command descriptions) **Added:** - cmd/query_test.go (simple stub test) ## Testing ✅ Build succeeds: gradle buildGo ✅ All tests pass: gradle testGo ✅ Lint clean: gradle lintGo ✅ No ANTLR/expr-lang imports remain ## Next Steps PR #2 will introduce Python DSL core matchers (calls(), variable(), flows()) 🤖 Generated with Claude Code
Owner
Author
shivasurya
added
enhancement
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #352 +/- ##
==========================================
+ Coverage 77.22% 80.75% +3.53%
==========================================
Files 60 59 -1
Lines 7325 6237 -1088
==========================================
- Hits 5657 5037 -620
+ Misses 1435 992 -443
+ Partials 233 208 -25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SafeDep Report Summary
No dependency changes detected. Nothing to scan. This report is generated by SafeDep Github App |
This was referenced Nov 9, 2025
shivasurya
changed the title
This was referenced Nov 9, 2025
Owner
Author
Merge activity
|
shivasurya
added a commit
that referenced
this pull request
Nov 10, 2025
## Summary Python DSL core matchers and rule decorator for security pattern definitions. ## Changes - Implemented `calls()` and `variable()` matchers - Added `@rule` decorator for metadata - JSON IR serialization for Go executor ## Testing - 36 tests, 97% coverage - All linters pass ## Stacked On PR #352
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes legacy ANTLR query parser and expr-lang evaluation system to prepare for new Python DSL architecture.
Breaking Changes
Files Changed
Testing
✅ Build succeeds
✅ All tests pass
✅ Lint clean
Next Steps
Python DSL implementation in stacked PR.
Co-Authored-By: Claude noreply@anthropic.com