Skip to content

chore(sast-engine): remove leftover Dockerfile and docker-compose.yml#715

Merged
shivasurya merged 1 commit into
mainfrom
shiva/remove-leftover-docker-fixtures
May 23, 2026
Merged

chore(sast-engine): remove leftover Dockerfile and docker-compose.yml#715
shivasurya merged 1 commit into
mainfrom
shiva/remove-leftover-docker-fixtures

Conversation

@shivasurya
Copy link
Copy Markdown
Owner

Summary

  • Delete sast-engine/Dockerfile and sast-engine/docker-compose.yml, both leftover dev artifacts from the Docker rule expansion in faa8ea019.
  • They are not referenced by any tests, docs, or build steps (Docker rule tests build their own fixtures via tmpDir + inline content).
  • They contain intentionally vulnerable rule-self-test patterns and were sitting at the top of sast-engine/, where the hosted scanner could mistake them for real code.

Test plan

  • go test ./... in sast-engine/ (all packages pass)
  • pytest in python-sdk/ (444 tests pass)
  • grep confirmed no source/test/doc file references sast-engine/Dockerfile or sast-engine/docker-compose.yml

These were dev artifacts left over from the Docker rule expansion in
faa8ea0 and no longer serve a purpose: no tests, docs, or build steps
reference them (Docker rule tests build their own fixtures via tmpDir
+ inline content). They also trip the hosted scanner on the sast-engine
subdirectory with rule-self-test patterns that aren't real code.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@shivasurya shivasurya added chore docker Docker/Dockerfile related changes labels May 23, 2026
@shivasurya shivasurya self-assigned this May 23, 2026
@safedep
Copy link
Copy Markdown

safedep Bot commented May 23, 2026

SafeDep Report Summary

Green Malicious Packages Badge Green Vulnerable Packages Badge Green Risky License Badge

No dependency changes detected. Nothing to scan.

View complete scan results →

This report is generated by SafeDep Github App

@code-pathfinder
Copy link
Copy Markdown

Pathfinder Report

No security findings on the changed files. This pull request is clean.

View report on the dashboard


Powered by Code Pathfinder.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.54%. Comparing base (a7e137f) to head (2868c7b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #715      +/-   ##
==========================================
- Coverage   85.56%   85.54%   -0.02%     
==========================================
  Files         191      191              
  Lines       27467    27467              
==========================================
- Hits        23503    23498       -5     
- Misses       3075     3079       +4     
- Partials      889      890       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shivasurya shivasurya merged commit 7a21c89 into main May 23, 2026
6 of 7 checks passed
@shivasurya shivasurya deleted the shiva/remove-leftover-docker-fixtures branch May 23, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore docker Docker/Dockerfile related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant