Skip to content

Test By Stress 245#364

Open
adiattlan wants to merge 1 commit intomainfrom
test-branch-245
Open

Test By Stress 245#364
adiattlan wants to merge 1 commit intomainfrom
test-branch-245

Conversation

@adiattlan
Copy link
Copy Markdown
Contributor

Description for STRESS 245

Copy link
Copy Markdown

@jit-ci-bandit jit-ci-bandit bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Jit has detected 2 important findings in this PR that you should review.
The findings are detailed below as separate comments.
It’s highly recommended that you fix these security issues before merge.

@@ -0,0 +1,4 @@
# flake8: noqa
a = "ASIAAQWSEDRFTGYHUJUJ"
output = subprocess.check_output(f"nslookup {domain}", shell=True, encoding='UTF-8')
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security control: Static Code Analysis Python Semgrep

Type: Python.Lang.Security.Audit.Subprocess-Shell-True.Subprocess-Shell-True

Description: Found 'subprocess' function 'check_output' with 'shell=True'. This is dangerous because this call will spawn the command using a shell process. Doing so propagates current shell settings and variables, which makes it much easier for a malicious actor to execute commands. Use 'shell=False' instead.

Severity: HIGH

Learn more about this issue


Fix suggestion:

This fix suggestion was generated by Jit. Please note that the suggestion might not always fit every use case. It is highly recommended that you check and review it before merging.

Suggestion guidelines

Use 'shell=False' instead

Suggested change
output = subprocess.check_output(f"nslookup {domain}", shell=True, encoding='UTF-8')
output = subprocess.check_output(f"nslookup {domain}", shell=False, encoding='UTF-8')

Jit Bot commands and options (e.g., ignore issue)

You can trigger Jit actions by commenting on this PR review:

  • #jit_ignore_fp Ignore and mark this specific single instance of finding as “False Positive”
  • #jit_ignore_accept Ignore and mark this specific single instance of finding as “Accept Risk”
  • #jit_undo_ignore Undo ignore command

@@ -0,0 +1,4 @@
# flake8: noqa
a = "ASIAAQWSEDRFTGYHUJUJ"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security control: Secret Detection

Type: Aws-Access-Token

Description: Identified a pattern that may indicate AWS credentials, risking unauthorized cloud resource access and data breaches on AWS platforms.

Severity: HIGH



Jit Bot commands and options (e.g., ignore issue)

You can trigger Jit actions by commenting on this PR review:

  • #jit_ignore_fp Ignore and mark this specific single instance of finding as “False Positive”
  • #jit_ignore_accept Ignore and mark this specific single instance of finding as “Accept Risk”
  • #jit_undo_ignore Undo ignore command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant