Fix Metrics dashboard button label contrast#607
Merged
shocknet-justin merged 1 commit intomainfrom Apr 18, 2026
Merged
Conversation
Remove misleading color="light" from clear IonButtons so labels use theme text color. Add dashboard-action-button class for contrast and use ion background for gradient card fill so light/dark stay aligned. Co-authored-by: Justin (shocknet) <shocknet-justin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Metrics main view used
IonButtonwithfill="clear"andcolor="light". In Ionic, that maps the button text color to the light palette (white in light mode, dark in dark mode), which clashed with the dark gradient-border card chrome—labels were effectively invisible in light theme.Changes
color="light"on Manage / Swaps / Assets & Liabilities actions.dashboard-action-buttonclass that sets--color: var(--ion-text-color)so labels follow the active theme.#16191cinner fill on.borderforvar(--ion-background-color)so the card matches light/dark backgrounds.Verification
npx vite buildsucceeds.