fix(http): return after reject so promise doesn't double-settle (#11)#32
Open
SAY-5 wants to merge 1 commit intoshoneslab:masterfrom
Open
fix(http): return after reject so promise doesn't double-settle (#11)#32SAY-5 wants to merge 1 commit intoshoneslab:masterfrom
SAY-5 wants to merge 1 commit intoshoneslab:masterfrom
Conversation
…eslab#11) Signed-off-by: SAY-5 <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11.
src/http.jshad two paths wherereject(...)was called but execution continued to a laterresolve(result), settling the same promise twice — first as rejected, then as fulfilled (the second settlement is a silent no-op but the wrong outcome wins for the caller's mental model and any logging that observes both signals).Locations
rejectwas called, then the request kept drainingdata/endand the parser eventually invokedresolve(result).xml2jsparsercallback (line 33):rejectthenresolve(result)ran on the next line unconditionally.Added
returnto both reject paths so the function exits cleanly on error.Test plan
node -c src/http.jssyntax checkresolve(undefined)from the parser path could produce confusing logs