Refactor: project review cleanup — dead code, DRY, data integrity#59
Merged
Refactor: project review cleanup — dead code, DRY, data integrity#59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Address quick-win and medium-effort items from March 2026 project review:
config.py, dead functions fromlogging.py, deadgenerate_tool_summaryfrom ADK, redundantis_recursivebranch inglob_tool.py, staleresolvers.pyreference from CLAUDE.md_find_document_in_kbsKB lookup helper, extract test context fixtures (task_store_ctx,memory_store_ctx,plan_store_ctx), consolidate 3 settings mutation patterns intoupdate_setting()methodset_input_callback()/clear_input_callback()API toBaseWorkflowManager, cache ripgrep availability check withlru_cacheingest_document()to add embeddings before updating in-memory state21 files changed, -30 lines net. 947 tests pass (9 new).
Test Plan
from agentic_cli import BaseCLIApp, BaseSettingsworksupdate_setting(),_find_document_in_kbs, input callback API, ripgrep cache