Skip to content

Refactor: project review cleanup — dead code, DRY, data integrity#59

Merged
shoom1 merged 13 commits intodevelopfrom
refactor/project-review-cleanup
Mar 10, 2026
Merged

Refactor: project review cleanup — dead code, DRY, data integrity#59
shoom1 merged 13 commits intodevelopfrom
refactor/project-review-cleanup

Conversation

@shoom1
Copy link
Copy Markdown
Owner

@shoom1 shoom1 commented Mar 10, 2026

Summary

Address quick-win and medium-effort items from March 2026 project review:

  • Dead code removal: Remove unused constants from config.py, dead functions from logging.py, dead generate_tool_summary from ADK, redundant is_recursive branch in glob_tool.py, stale resolvers.py reference from CLAUDE.md
  • DRY fixes: Extract _find_document_in_kbs KB lookup helper, extract test context fixtures (task_store_ctx, memory_store_ctx, plan_store_ctx), consolidate 3 settings mutation patterns into update_setting() method
  • Coupling reduction: Add public set_input_callback()/clear_input_callback() API to BaseWorkflowManager, cache ripgrep availability check with lru_cache
  • Data integrity: Swap vector store save order (mappings before FAISS index) for crash safety, reorder ingest_document() to add embeddings before updating in-memory state

21 files changed, -30 lines net. 947 tests pass (9 new).

Test Plan

  • Full test suite: 947 passed, 6 skipped, 27 xfailed
  • Import verification: from agentic_cli import BaseCLIApp, BaseSettings works
  • New tests for update_setting(), _find_document_in_kbs, input callback API, ripgrep cache

@shoom1 shoom1 merged commit 45d00d9 into develop Mar 10, 2026
@shoom1 shoom1 mentioned this pull request Mar 11, 2026
2 tasks
@shoom1 shoom1 deleted the refactor/project-review-cleanup branch April 18, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant