chore: rename AvoidScientificNotation to UseScientificNotation#416
Merged
chore: rename AvoidScientificNotation to UseScientificNotation#416
Conversation
ccoVeille
reviewed
Mar 18, 2026
| // digits are unknown. With this set to false, that number would be expressed as "1.2E3" instead. | ||
| var AvoidScientificNotation = true | ||
| // digits are unknown. With this set to true, that number would be expressed as "1.2E3" instead. | ||
| var UseScientificNotation = false |
There was a problem hiding this comment.
I'm worried about this PR
A public variable name was renamed, which mean it's a breaking change in the API.
There are code out there that will stop working.
The variable could have been kept with a //Deprecated: tag
I don't think it's a real issue because the last published tag doesn't contain the old variable yet.
But I wanted to share my surprise.
I'm curious about your feedback here
Member
Author
There was a problem hiding this comment.
Yes, this is a breaking change, but this variable was added between the 1.4.0 release and the next upcoming release. I was fine with doing it just because of that, otherwise I would not touch it under any circumstances
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #389 (comment) we should use positive sounding variable to decrease confusion and cognitive load for end users.