fix: uninstall lifecycle#66
Merged
Merged
Conversation
David Neustadt (dneustadt)
force-pushed
the
fix/uninstall-lifecycle
branch
from
db9acfa to
742a263
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #66 +/- ##
============================================
+ Coverage 81.72% 82.20% +0.48%
Complexity 135 135
============================================
Files 21 21
Lines 662 663 +1
============================================
+ Hits 541 545 +4
+ Misses 121 118 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
David Neustadt (dneustadt)
force-pushed
the
fix/uninstall-lifecycle
branch
from
d78d9a2 to
11afa31
Compare
Dominik Grothaus (dgrothaus-sw)
requested changes
Jun 18, 2026
| "name": "swag/language-pack", | ||
| "description": "Language pack for Shopware 6", | ||
| "version": "5.56.0", | ||
| "version": "5.57.0", |
Contributor
There was a problem hiding this comment.
Language Pack does not require a manual version increase. The version is increased automatically during the scheduled release each Friday.
| $plugin = new SwagLanguagePack(true, ''); | ||
| $container = $this->createMock(ContainerInterface::class); | ||
| $connection = $this->createMock(Connection::class); | ||
| $container->expects(static::once())->method('get')->willReturn($connection); |
Contributor
There was a problem hiding this comment.
Please change to
$container->expects(static::once())->method('get')
->with(Connection::class)
->willReturn($connection);As this is a mocked object, this test would still succeed if someone would change the tested class geting some other object from the container.
| $connection = $this->createMock(Connection::class); | ||
| $container->expects(static::once())->method('get')->willReturn($connection); | ||
| $reflection = new \ReflectionProperty(SwagLanguagePack::class, 'container'); | ||
| $reflection->setValue($plugin, $container); |
Contributor
There was a problem hiding this comment.
You can simply $plugin->setContainer($container) instead of using a reflection class here.
David Neustadt (dneustadt)
requested a review
from Dominik Grothaus (dgrothaus-sw)
Dominik Grothaus (dgrothaus-sw)
approved these changes
Jun 18, 2026
Martin Krzykawski (MartinKrzykawski)
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the
uninstallmethod inSwagLanguagePack.phpto instantiate theLifecycleclass directly with aConnectionobject, rather than retrievingLifecyclefrom the container. This fixes a race condition whereLifecycleis already no longer registered as a service in the DI container when theuninstallmethod is called.