Skip to content

Update code guidelines from platform#2241

Merged
Bojan Rajh (bojanrajh) merged 1 commit intomainfrom
code-guidelines-update
Apr 16, 2026
Merged

Update code guidelines from platform#2241
Bojan Rajh (bojanrajh) merged 1 commit intomainfrom
code-guidelines-update

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Mirrored from: shopware/shopware

@lasomethingsomething
Copy link
Copy Markdown
Contributor

Hey Su (@sushmangupta) Bojan Rajh (@bojanrajh) Micha Hobert (@Isengo1989), I took a quick look at this and it wants to reintroduce a bunch of errors (old paths, file names with typos, spelling mistakes). Can close if it's OK.

@github-actions github-actions Bot force-pushed the code-guidelines-update branch from 70f29c1 to 67d67e9 Compare April 16, 2026 09:37
@bojanrajh
Copy link
Copy Markdown
Contributor

somethings (@lasomethingsomething) I'm afraid the original documents are copied from here, therefore they need to be changed there.

@lasomethingsomething
Copy link
Copy Markdown
Contributor

Bojan Rajh (@bojanrajh) I'm not able to do that, I need to focus on PM work.

@Isengo1989
Copy link
Copy Markdown
Contributor

Bojan Rajh (Bojan Rajh (@bojanrajh)) I'm not able to do that, I need to focus on PM work.

We do not change these files here, as Bojan mentioned. This is also mentioned here -> https://github.com/shopware/docs?tab=readme-ov-file#synced-files

To avoid open PRs and changes we will merge this. Feel free to submit a PR on shopware/shopware in the meantime, i will create a ticket on that for us as well, but we also have other focus topics.

Our fix commands will typically not look into that, so please do not touch those files in future PRs.

@bojanrajh Bojan Rajh (bojanrajh) merged commit 5029a16 into main Apr 16, 2026
1 check passed
@bojanrajh Bojan Rajh (bojanrajh) deleted the code-guidelines-update branch April 16, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants