Skip to content

fix(api-gen): better validation rule for COMPONENTS_API_ALIAS flag and proper overrides loading#1082

Merged
Patryk Tomczyk (patzick) merged 2 commits intomainfrom
fix-api-gen-rules
Jul 2, 2024
Merged

fix(api-gen): better validation rule for COMPONENTS_API_ALIAS flag and proper overrides loading#1082
Patryk Tomczyk (patzick) merged 2 commits intomainfrom
fix-api-gen-rules

Conversation

@patzick
Copy link
Copy Markdown
Contributor

Description

  • fixes problem with overrides loading
  • improves validation message suggesting that schema component name might be incorrect
  • added more tests for the rule
image

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo ✅ Ready (Inspect) Visit Preview Jul 2, 2024 0:25am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Jul 2, 2024 0:25am

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jul 2, 2024

CodSpeed Performance Report

Merging #1082 will not alter performance

Comparing fix-api-gen-rules (fd24608) with main (39faaa3)

Summary

✅ 9 untouched benchmarks

Copy link
Copy Markdown
Contributor

@mkucmus Maciek Kucmus (mkucmus) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@patzick Patryk Tomczyk (patzick) merged commit db42df4 into main Jul 2, 2024
@patzick Patryk Tomczyk (patzick) deleted the fix-api-gen-rules branch July 2, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants