chore(deps): update tresjs #2209
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the 3D rendering stack to the latest versions (three.js 0.182.0, @tresjs/core 5.2.1, @tresjs/cientos 5.2.1) and integrates the actual 3D viewer into the CMS image gallery, replacing the previous placeholder implementation.
- Updated three.js and TresJS libraries to their latest major versions
- Refactored SwMedia3D component to use the new @tresjs/cientos v5 API
- Integrated SwMedia3D viewer into the CMS image gallery with SSR-safe client-only wrapper
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Updates dependency versions and lockfile entries for three.js (0.182.0), @tresjs/core (5.2.1), @tresjs/cientos (5.2.1), and their transitive dependencies |
| packages/cms-base-layer/package.json | Updates package.json dependencies to match the new versions of three.js and TresJS libraries |
| packages/cms-base-layer/app/components/SwMedia3D.vue | Refactors component to use new @tresjs/cientos v5 API with state.value?.scene pattern and computed wrapper |
| packages/cms-base-layer/app/components/public/cms/element/CmsElementImageGallery.vue | Replaces 3D placeholder with actual SwMedia3D viewer wrapped in client-only component |
| packages/composables/src/devtools/plugin.ts | Removes unused DevtoolsPluginApi type import and loosens type to any for compatibility with @vue/devtools-api v7 |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/cms-base-layer/app/components/public/cms/element/CmsElementImageGallery.vue
Show resolved
Hide resolved
mkucmus
left a comment
mkucmus
left a comment
There was a problem hiding this comment.
I think this pretty component deserves for one small improvement - consider implementing a skeleton fallback
| </span> | ||
| <client-only> | ||
| <SwMedia3D :src="currentImage.url" /> | ||
| </client-only> |
There was a problem hiding this comment.
please add <template #fallback> with a skeleton to be SSR friendly if this item of gallery can be first one.
ignore if the whole gallery has its own fallback component
…mizer to 0.22.0; fix conditional rendering in SwMedia3D component
|
looks good to merge after @mkucmus comment |
This pull request updates the 3D rendering stack to the latest versions and improves the integration of 3D media within the CMS image gallery. The most significant changes involve upgrading the
three.jsand@tresjslibraries, refactoring theSwMedia3Dcomponent for compatibility, and replacing the 3D placeholder in the image gallery with the actual 3D viewer.3D Rendering Stack Upgrades and Integration:
Upgraded
three,@tresjs/core, and@tresjs/cientosto their latest major versions (three@0.182.0,@tresjs/core@5.2.1,@tresjs/cientos@5.2.1) in bothpackage.jsonandpnpm-lock.yaml, ensuring improved features and compatibility. [1] [2] [3] [4] [5] [6] [7] [8] [9]Updated related dependencies and their peer dependencies in lockfile, including
three-stdlib,camera-controls, andstats-gl, to match the newthree.jsversion. [1] [2] [3] [4]Component Refactoring and Gallery Integration:
Refactored
SwMedia3D.vueto use the new API from@tresjs/cientosv5, switching from destructuringsceneto accessing it viastate.value?.sceneand wrapping it in a Vuecomputedproperty for reactivity. [1] [2]Updated the CMS image gallery (
CmsElementImageGallery.vue) to replace the static 3D placeholder with the actualSwMedia3Dviewer component, wrapped inclient-onlyto ensure correct SSR behavior.Minor and Maintenance Changes:
Removed an unused type import and loosened a type in the devtools plugin for now, to avoid type errors. [1] [2]
Lockfile cleanup: removed unused packages and added new dependencies required by the updated stack. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]
These changes ensure that the CMS is using the latest, most secure, and best-performing 3D rendering libraries, and that the 3D media experience in the gallery is now interactive and up-to-date.