feat: add newsletter subscription confirmation page and translations #2222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a newsletter subscription confirmation page with internationalization support for German, English, and Polish languages. The implementation includes proper error handling, loading states, and user feedback messages.
Changes:
- Added a new Vue page component for newsletter subscription confirmation that processes email confirmation tokens from URL query parameters
- Introduced localized newsletter translation files with subscription-related messages for three languages (de-DE, en-GB, pl-PL)
- Updated language index files to integrate the new newsletter translations into the i18n system
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
templates/vue-starter-template/app/pages/newsletter-subscribe.vue |
New confirmation page that handles newsletter subscription verification via API with loading and error states |
templates/vue-starter-template/i18n/de-DE/newsletter.json |
German translations for newsletter-related UI text and messages |
templates/vue-starter-template/i18n/en-GB/newsletter.json |
English translations for newsletter-related UI text and messages |
templates/vue-starter-template/i18n/pl-PL/newsletter.json |
Polish translations for newsletter-related UI text and messages |
templates/vue-starter-template/i18n/de-DE/de-DE.ts |
Import and merge newsletter translations into German language exports |
templates/vue-starter-template/i18n/en-GB/en-GB.ts |
Import and merge newsletter translations into English language exports |
templates/vue-starter-template/i18n/pl-PL/pl-PL.ts |
Import and merge newsletter translations into Polish language exports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
templates/vue-starter-template/app/pages/newsletter-subscribe.vue
Outdated
Show resolved
Hide resolved
vercel
bot
temporarily deployed
to
Preview – shopware-frontends-docs
patzick
requested changes
Jan 14, 2026
Contributor
patzick
left a comment
patzick
left a comment
There was a problem hiding this comment.
We need action button for the user for what to do next and we need some space before footer as this feels very tight (as on screenshot)
vercel
bot
temporarily deployed
to
Preview – shopware-frontends-docs
mkucmus
approved these changes
Jan 19, 2026
patzick
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a newsletter subscription confirmation page and introduces localized newsletter-related translations in German, English, and Polish. The main focus is on providing a user interface for newsletter confirmation and ensuring proper internationalization support.
Newsletter Subscription Confirmation Page:
newsletter-subscribe.vue) that confirms newsletter subscription status, displays loading and error states, and uses localized messages for user feedback.Internationalization (i18n) Enhancements:
newsletter.jsontranslation files for German (de-DE), English (en-GB), and Polish (pl-PL) with newsletter-specific strings. [1] [2] [3]de-DE.ts,en-GB.ts,pl-PL.ts) to import and merge the new newsletter translations. [1] [2]closes #1993