feat: update components for improved accessibility and styling#2268
Merged
Patryk Tomczyk (patzick) merged 4 commits intomainfrom Feb 4, 2026
Merged
feat: update components for improved accessibility and styling#2268Patryk Tomczyk (patzick) merged 4 commits intomainfrom
Patryk Tomczyk (patzick) merged 4 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves accessibility and styling across the CMS base-layer components and the Vue starter template, including adding tooling support for automated a11y checks.
Changes:
- Added
@nuxt/a11y(andaxe-corevia lockfile) and enabled the module in the starter template. - Improved landmark/semantic structure and added ARIA labels in layouts and header controls.
- Updated several CMS base-layer components (filters/sort/product name/sections) to adjust semantics and reduce redundant interactive elements.
Reviewed changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/vue-starter-template/package.json | Adds @nuxt/a11y dependency to the starter template. |
| templates/vue-starter-template/nuxt.config.ts | Enables @nuxt/a11y module. |
| templates/vue-starter-template/i18n/pl-PL/layout.json | Adds header translation strings for new aria-label usage. |
| templates/vue-starter-template/i18n/en-GB/layout.json | Adds header translation strings for new aria-label usage. |
| templates/vue-starter-template/i18n/de-DE/layout.json | Adds header translation strings for new aria-label usage. |
| templates/vue-starter-template/app/pages/account/order/details/[id].vue | Adjusts page structure to avoid an extra <main> element. |
| templates/vue-starter-template/app/layouts/default.vue | Adds an aria-label to the main landmark. |
| templates/vue-starter-template/app/layouts/checkout.vue | Adds an aria-label to the main landmark for checkout layout. |
| templates/vue-starter-template/app/layouts/account.vue | Switches sidebar to <nav> with an accessible label. |
| templates/vue-starter-template/app/components/layout/header/TopNavigation.vue | Refactors top navigation markup and adds ARIA attributes. |
| templates/vue-starter-template/app/components/layout/footer/NewsletterBox.vue | Adjusts semantics and text styling for footer newsletter box. |
| templates/vue-starter-template/app/components/layout/Header.vue | Adds localized aria-labels to icon buttons (account/cart). |
| templates/vue-starter-template/app/components/form/BaseInput.vue | Tweaks input styling and placeholder color for better contrast/readability. |
| templates/vue-starter-template/app/components/FrontendNavigationPage.vue | Adds a category title heading and wraps page content in a container. |
| pnpm-lock.yaml | Locks new dependencies and updates transitive dependency resolution. |
| packages/cms-base-layer/app/components/public/cms/section/CmsSectionSidebar.vue | Replaces nested <main> with <div> in section layout. |
| packages/cms-base-layer/app/components/public/cms/element/CmsElementProductName.vue | Attempts to make product name semantic by wrapping in <h1>. |
| packages/cms-base-layer/app/components/public/cms/block/CmsBlockCenterText.vue | Adjusts image styling in center-text block. |
| packages/cms-base-layer/app/components/listing-filters/SwFilterShippingFree.vue | Removes nested icon button and makes chevron decorative. |
| packages/cms-base-layer/app/components/listing-filters/SwFilterRating.vue | Removes nested icon button and makes chevron decorative. |
| packages/cms-base-layer/app/components/listing-filters/SwFilterProperties.vue | Removes redundant click handling; relies on checkbox/label semantics. |
| packages/cms-base-layer/app/components/listing-filters/SwFilterPrice.vue | Removes nested icon button and makes chevron decorative. |
| packages/cms-base-layer/app/components/SwVariantConfigurator.vue | Adjusts option group label semantics. |
| packages/cms-base-layer/app/components/SwSortDropdown.vue | Improves aria-expanded behavior and adjusts chevron accessibility. |
| .changeset/lazy-mirrors-learn.md | Documents the CMS base-layer a11y improvements as a minor bump. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/cms-base-layer/app/components/public/cms/element/CmsElementProductName.vue
Outdated
Show resolved
Hide resolved
templates/vue-starter-template/app/components/layout/header/TopNavigation.vue
Show resolved
Hide resolved
templates/vue-starter-template/app/components/layout/header/TopNavigation.vue
Outdated
Show resolved
Hide resolved
templates/vue-starter-template/app/components/layout/header/TopNavigation.vue
Outdated
Show resolved
Hide resolved
Patryk Tomczyk (patzick)
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving the accessibility (A11y) of the CMS base layer components. The changes include enhancements to ARIA attributes, semantic markup, and the removal of unnecessary or redundant elements to make the UI more accessible. Additionally, there are some dependency updates and minor style adjustments.
Accessibility Improvements:
SwSortDropdown.vue,SwFilterPrice.vue,SwFilterProperties.vue,SwFilterRating.vue,SwFilterShippingFree.vue). [1] [2] [3] [4] [5] [6] [7]<h1>for product name,<div>instead of<h3>for option group labels) to improve document structure and accessibility (CmsElementProductName.vue,SwVariantConfigurator.vue). [1] [2]Dependency and Configuration Updates:
@nuxt/a11yandaxe-coreas new dependencies to support accessibility testing and improvements (pnpm-lock.yaml). [1] [2] [3] [4]sassas a dependency for@vitejs/plugin-vuein several places (pnpm-lock.yaml). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Minor Layout and Style Adjustments:
CmsBlockCenterText.vue,CmsSectionSidebar.vue). [1] [2]Changelog:
@shopware/cms-base-layer.close #2267