fix(vue-demo-store): use bound src attributes for public images#2401
Merged
Maciej D (mdanilowicz) merged 2 commits intomainfrom Apr 16, 2026
Merged
fix(vue-demo-store): use bound src attributes for public images#2401Maciej D (mdanilowicz) merged 2 commits intomainfrom
Maciej D (mdanilowicz) merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the vue-demo-store Nuxt/Vue templates to use bound :src attributes for a couple of images located in public/, and adds a Changesets entry describing the patch.
Changes:
- Switched several
<img>tags fromsrc="/…"to:src="'/…'"forlogo.svgandmaintenance_mode.svg. - Added a patch changeset documenting the change.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/vue-demo-store/app/components/layout/LayoutHeader.vue | Changes the header logo image to a bound :src. |
| templates/vue-demo-store/app/components/layout/LayoutFooter.vue | Changes the footer logo image to a bound :src. |
| templates/vue-demo-store/app/components/layout/LayoutCheckoutHeader.vue | Changes the checkout header logo image to a bound :src. |
| templates/vue-demo-store/app/components/errors/MaintainMode.vue | Changes the maintenance illustration to a bound :src. |
| templates/vue-demo-store/app/components/account/AccountLoginForm.vue | Changes the login modal logo image to a bound :src. |
| .changeset/wide-spoons-grin.md | Adds a patch changeset entry for vue-demo-store. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Maciej D (mdanilowicz)
requested review from
Björn Meyer (BrocksiNet),
Maciek Kucmus (mkucmus) and
Patryk Tomczyk (patzick)
Maciek Kucmus (mkucmus)
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a patch-level update to the
vue-demo-storeby ensuring that all public image sources use bound:srcattributes in Vue templates. This change ensures asset URLs are handled consistently by the Vue template compiler, which can help avoid issues with asset resolution, especially in production environments.Consistent image asset handling:
vue-demo-storecomponents to use bound:srcattributes instead of staticsrcattributes, notably for/logo.svgand/maintenance_mode.svg, to ensure consistent asset URL handling by the Vue template compiler. [1] [2] [3] [4] [5]Documentation:
:srcattributes for public images.