fix(composables): adds parameter to loadMore to accept an optional query#380
Merged
Patryk Tomczyk (patzick) merged 2 commits intoshopware:mainfrom Sep 4, 2023
Conversation
|
Someone is attempting to deploy a commit to the Shopware Frontends Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Patryk Tomczyk (patzick)
approved these changes
Sep 4, 2023
Contributor
Patryk Tomczyk (patzick)
left a comment
Patryk Tomczyk (patzick)
left a comment
There was a problem hiding this comment.
Looks good! Thanks :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I'm marking this as a bugfix, as I assume it was not intended for the function to not have a query parameter. Should close #379.
The current problem is that filters, if set, will not be applied to the query on loadMore. This means, that when using a non-pagination style of content fetching, the functionality breaks there.
Type of change
Additional context
I was trying to follow the contributing guidelines as well as I could, but please check if I missed something when making this edit (like documentation or something like that).