Skip to content

fix(gen-api): additional properties#928

Merged
Maciek Kucmus (mkucmus) merged 2 commits intomainfrom
fix/additional-properties-openapi
May 21, 2024
Merged

fix(gen-api): additional properties#928
Maciek Kucmus (mkucmus) merged 2 commits intomainfrom
fix/additional-properties-openapi

Conversation

@mdanilowicz
Copy link
Copy Markdown
Contributor

Description

From

    OrderRouteResponse: {
      paymentChangeable?: GenericRecord;
    };

To

    OrderRouteResponse: {
      paymentChangeable?: {
        [key: string]: boolean;
      };
    };

Type of change

ToDo's

Screenshots (if applicable)

Additional context

@vercel
Copy link
Copy Markdown

vercel Bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo ✅ Ready (Inspect) Visit Preview May 21, 2024 8:55am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview May 21, 2024 8:55am

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 15, 2024

CodSpeed Performance Report

Merging #928 will not alter performance

Comparing fix/additional-properties-openapi (ccb9de7) with main (04ac2ad)

Summary

✅ 9 untouched benchmarks

Copy link
Copy Markdown
Contributor

@mkucmus Maciek Kucmus (mkucmus) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants