fix: handle ChildrenAssociationField with self::class reference#35
Closed
Soner (shyim) wants to merge 1 commit into
Closed
fix: handle ChildrenAssociationField with self::class reference#35Soner (shyim) wants to merge 1 commit into
Soner (shyim) wants to merge 1 commit into
Conversation
The DAL definition collector threw "Cannot handle field" when a ChildrenAssociationField was constructed with a non-string reference argument like self::class. Hoist the field to the early special-case block since its property name is always "children".
Contributor
|
Soner (@shyim) the propertyName could be something else than |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DALDefinitionCollectorthrewRuntimeException: Cannot handle field ...ChildrenAssociationField with arguments [...]when an entity definition usednew ChildrenAssociationField(self::class)(or any non-string reference argument).ChildrenAssociationField's property name is always'children'(default), andself::classis aClassConstFetchnode without avalueproperty — so it fell through to the generic branch and blew up.ChildrenAssociationFieldcheck into the early special-case block alongsideChildCountField,ParentAssociationField, etc. The unreachable inner branch was removed.Test plan
children-association-self-class.phpexercisingnew ChildrenAssociationField(self::class)vendor/bin/phpunit tests/Rule/BestPractise/DALDefinitionRuleTest.php— all 4 tests pass