feat/project create use proper php version#1004
Conversation
Soner (shyim)
commented
May 12, 2026
- feat: use proper php version for creation
- feat: enhance PHP version handling in project creation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 29a21d131b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| if strings.HasPrefix(chosenVersion, "dev-") { | ||
| return nil |
There was a problem hiding this comment.
Resolve PHP constraint for dev versions
Dropping all dev-* versions to nil here means project create --docker ... dev-... never uses the package’s declared require.php and later falls back to phpConstraint.HighestSupported() (currently 8.5) in cmd/project/project_create.go. If the targeted dev branch is not compatible with that PHP version, Composer install fails even though the constraint metadata is already available in releases.
Useful? React with 👍 / 👎.