Skip to content

feat/project create use proper php version#1004

Merged
Soner (shyim) merged 2 commits into
nextfrom
feat/project-create-use-proper-php-version
May 12, 2026
Merged

feat/project create use proper php version#1004
Soner (shyim) merged 2 commits into
nextfrom
feat/project-create-use-proper-php-version

Conversation

@shyim

Copy link
Copy Markdown
Member
  • feat: use proper php version for creation
  • feat: enhance PHP version handling in project creation

@shyim Soner (shyim) merged commit 559b514 into next May 12, 2026
5 checks passed
@shyim Soner (shyim) deleted the feat/project-create-use-proper-php-version branch May 12, 2026 08:24

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 29a21d131b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Comment on lines +96 to +97
if strings.HasPrefix(chosenVersion, "dev-") {
return nil

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Resolve PHP constraint for dev versions

Dropping all dev-* versions to nil here means project create --docker ... dev-... never uses the package’s declared require.php and later falls back to phpConstraint.HighestSupported() (currently 8.5) in cmd/project/project_create.go. If the targeted dev branch is not compatible with that PHP version, Composer install fails even though the constraint metadata is already available in releases.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants