feat: warn about known security advisories before project creation#1006
Merged
Merged
Conversation
Fetches packagist security advisories for the chosen shopware/core version and prompts the user to continue (auto-enabling --no-audit so composer install proceeds) or cancel. Non-interactive runs abort unless --no-audit was explicitly passed.
Soner (shyim)
force-pushed
the
feat/project-create-security-advisory-check
branch
from
1e9fc09 to
bb70bca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shopware/coreand filters to the chosen version before any folder is created.--no-auditso composer install proceeds; no cancels.--no-auditwas already passed.Test plan
go test ./internal/packagist/... ./cmd/project/...shopware-cli project create test-vuln 6.6.10.14(a version known to have advisories) — verify the styled block and the interactive prompt--no-interaction— verify it aborts unless--no-auditis passedshopware-cli project create test-clean latest— verify no advisory block appears for the latest version