fix(devtui): surface config save errors to the user#1029
Merged
Conversation
WriteConfig/WriteLocalConfig errors in the config tab were discarded, so a failed write (disk full, permissions) showed a "Saved" badge while data was not persisted. Propagate the error through configSavedMsg, display it under the save row, and swap the button to "Retry Save".
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b19ce73c1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Codex review on #1029 flagged a race: an async configSavedMsg returning after the user typed more changes would clear `modified` and mask the newer unsaved edits. Config writes are local file ops — do them inline, update saved/modified/err directly, and drop the now-unused message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WriteConfig/WriteLocalConfigerrors from the config tab throughconfigSavedMsginstead of discarding them with_ =CODE_IMPROVEMENTS.mdPreviously a failed write (disk full, read-only mount, permissions) still displayed a green "Saved" badge while the config was never persisted.
Test plan
go build ./...go vet ./internal/devtui/go test ./internal/devtui/chmod -w .shopware-project.yml) and confirm the error overlay renders and Retry Save re-attempts the write