refactor(executor): add NewLocalWithConfig and replace string literals with type constants#1049
Conversation
…s with type constants Add NewLocalWithConfig factory function for creating local executors with project and environment configuration. Refactor NewLocal to delegate to it. Replace magic string literals in factory.go with exported type constants. Update CI command to use NewLocalWithConfig directly, and configure the executor in extension build/zip commands when ShopwareRoot is set.
💡 Codex Reviewshopware-cli/internal/shop/config.go Line 56 in f51918d When an environment key exists but is set to ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback". |
Summary
NewLocalWithConfigfactory function to create local executors with project and environment configurationfactory.gowith exported type constants (TypeLocal,TypeSymfonyCLI,TypeDocker)NewLocalto delegate toNewLocalWithConfigfor consistencyNewLocalWithConfigdirectly and restructure config loadingShopwareRootis setTest plan
go test ./internal/executor/...passesgo build ./...succeeds