feat: add shopware/conflicts composer repository to generated composer.json#1160
Merged
Merged
Conversation
…r.json The shopware/conflicts package will be served from a composer repository on GitHub Pages. Since composer only honors repositories of the root package, projects need the repository entry themselves: - project create: always include it in the generated composer.json - flex migration: add it when missing, without duplicating an existing entry Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1160 +/- ##
==========================================
+ Coverage 47.33% 47.35% +0.02%
==========================================
Files 230 230
Lines 16501 16509 +8
==========================================
+ Hits 7810 7818 +8
Misses 8691 8691
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
shopware/conflictspackage will be served from a composer repository hosted on GitHub Pages (https://shopware.github.io/conflicts/), and shopware/platform is adding that repository to its own composer.json. Since composer only honorsrepositoriesdefined in the root package, projects created or migrated by shopware-cli need the entry themselves.What
project create(packagist.GenerateComposerJson): the generated composer.json now always contains the conflicts composer repository alongside the existingpathrepositories.flexmigrator.MigrateComposerJson): adds the repository when it is missing, guarded byHasRepositoryso an existing entry is not duplicated.🤖 Generated with Claude Code