Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes path handling issues by replacing the path package with path/filepath for filesystem operations and corrects several related issues.
Changes:
- Replaced
pathimport withpath/filepathin platform.go and bundle.go for proper cross-platform path handling - Fixed a bug where
defaultNotAllowedPathsglobal slice was being mutated by usingslices.Clone - Replaced string concatenation with
filepath.Joinfor path construction in zip.go - Changed
context.Background()to use the providedctxparameter in GetPhpVersion function - Corrected error message from "manifest.xml" to "composer.json" in build_modifier.go
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/extension/zip.go | Fixed global slice mutation bug using slices.Clone; replaced string concatenation with filepath.Join for path construction |
| internal/extension/platform.go | Replaced path package with path/filepath for filesystem operations; fixed context usage in GetPhpVersion |
| internal/extension/bundle.go | Replaced path package with path/filepath for filesystem operations |
| internal/extension/build_modifier.go | Fixed error message typo (manifest.xml → composer.json) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.