Skip to content

fix: the usage of path.join#822

Merged
shyim merged 1 commit intomainfrom
fix/correct-usage-of-file-pkg
Feb 1, 2026
Merged

fix: the usage of path.join#822
shyim merged 1 commit intomainfrom
fix/correct-usage-of-file-pkg

Conversation

@shyim
Copy link
Member

@shyim shyim commented Feb 1, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 1, 2026 18:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes path handling issues by replacing the path package with path/filepath for filesystem operations and corrects several related issues.

Changes:

  • Replaced path import with path/filepath in platform.go and bundle.go for proper cross-platform path handling
  • Fixed a bug where defaultNotAllowedPaths global slice was being mutated by using slices.Clone
  • Replaced string concatenation with filepath.Join for path construction in zip.go
  • Changed context.Background() to use the provided ctx parameter in GetPhpVersion function
  • Corrected error message from "manifest.xml" to "composer.json" in build_modifier.go

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
internal/extension/zip.go Fixed global slice mutation bug using slices.Clone; replaced string concatenation with filepath.Join for path construction
internal/extension/platform.go Replaced path package with path/filepath for filesystem operations; fixed context usage in GetPhpVersion
internal/extension/bundle.go Replaced path package with path/filepath for filesystem operations
internal/extension/build_modifier.go Fixed error message typo (manifest.xml → composer.json)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@shyim shyim merged commit c647c89 into main Feb 1, 2026
9 checks passed
@shyim shyim deleted the fix/correct-usage-of-file-pkg branch February 1, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant