feat: optimize memory usage for parallel database dump#854
Merged
Soner (shyim) merged 4 commits intoshopware:mainfrom Feb 17, 2026
Merged
feat: optimize memory usage for parallel database dump#854Soner (shyim) merged 4 commits intoshopware:mainfrom
Soner (shyim) merged 4 commits intoshopware:mainfrom
Conversation
82d21cd to
e2b5a34
Compare
Soner (shyim)
approved these changes
Feb 17, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation would buffer all generated SQL in memory before writing to a file / stdout, which could use a lot of memory, even for relatively small databases.
The new implementation avoids this problem by first dumping the tables into temporary files and than copying the data from those files into the final file / stdout as soon as possible.
In my tests using, a local database, the max RSS went from 13712388 kbytes (!) to 73844 kbytes while also taking less time (~32.4s vs ~25.5s).