refactor: replace custom table implementation with lipgloss table component#883
Merged
Soner (shyim) merged 2 commits intomainfrom Mar 2, 2026
Merged
refactor: replace custom table implementation with lipgloss table component#883Soner (shyim) merged 2 commits intomainfrom
Soner (shyim) merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the custom internal/table rendering implementation and updates CLI commands to render tables using the charm.land/lipgloss/v2/table component directly.
Changes:
- Deleted the custom table writer (
internal/table/table.go). - Updated multiple
cmd/*commands to build and render tables vialipgloss/v2/table. - Standardized table rendering in the touched commands to
Border(lipgloss.NormalBorder())+Headers(...)+Row(...).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/table/table.go | Removes the bespoke table writer implementation. |
| cmd/project/project_extension_outdated.go | Switches “outdated extensions” output to lipgloss/table. |
| cmd/project/project_extension_list.go | Switches “extension list” output to lipgloss/table. |
| cmd/account/account_producer_extension_list.go | Switches producer extension list output to lipgloss/table. |
| cmd/account/account_company_list.go | Switches account company list output to lipgloss/table. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.