Skip to content

feat: simplify selection of project creation#890

Merged
Soner (shyim) merged 6 commits intomainfrom
feat/simplify-create-steps
Mar 3, 2026
Merged

feat: simplify selection of project creation#890
Soner (shyim) merged 6 commits intomainfrom
feat/simplify-create-steps

Conversation

@shyim
Copy link
Copy Markdown
Member

@shyim Soner (shyim) commented Mar 3, 2026

asciicast

Copilot AI review requested due to automatic review settings March 3, 2026 12:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces usage tracking and a more guided interactive flow for project create, while also improving shutdown handling and Docker-based Composer behavior.

Changes:

  • Add a new internal/tracking package that resolves a stable user ID and emits UDP tracking events, plus accompanying tests.
  • Update project create to use a simplified version selection UI (grouped selection) and optionally hide “advanced” configuration.
  • Add signal-aware root context cancellation and introduce a Docker mountability helper used during Docker-based Composer installs.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
internal/tracking/tracking.go Implements stable ID resolution and UDP event emission for tracking.
internal/tracking/tracking_test.go Adds unit tests for tracking payload sending and ID resolution behavior.
internal/system/docker.go Adds IsDockerMountable() helper used by Docker Composer install path.
cmd/root.go Cancels the root command context on SIGINT/SIGTERM.
cmd/project/project_create.go Reworks interactive prompts (version selection + advanced toggle), emits a project.create tracking event, and tweaks Docker composer args/mounts.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/tracking/tracking.go Outdated
Comment thread internal/tracking/tracking_test.go
Comment thread cmd/project/project_create.go
Comment thread cmd/project/project_create.go
Comment thread internal/system/docker_unix.go
Comment thread internal/tracking/tracking_test.go
Comment thread internal/tracking/tracking_test.go
Comment thread internal/tracking/tracking_test.go
Comment thread internal/tracking/tracking_test.go
Comment thread internal/tracking/tracking_test.go
@shyim Soner (shyim) merged commit c5ec9f0 into main Mar 3, 2026
3 checks passed
@shyim Soner (shyim) deleted the feat/simplify-create-steps branch March 3, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants