fix: fix labels management for scheduled_task#194
Merged
Patrick Derks (TrayserCassa) merged 7 commits intomainfrom Apr 17, 2026
Merged
fix: fix labels management for scheduled_task#194Patrick Derks (TrayserCassa) merged 7 commits intomainfrom
Patrick Derks (TrayserCassa) merged 7 commits intomainfrom
Conversation
Patrick Derks (TrayserCassa)
approved these changes
Apr 17, 2026
Renaud Hager (renaudhager)
force-pushed
the
fix/scheduled-task-labels
branch
from
9d978a7 to
418a9f2
Compare
This reverts commit e2497c0.
Renaud Hager (renaudhager)
force-pushed
the
fix/scheduled-task-labels
branch
from
418a9f2 to
fe7bfb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for configuring scheduled task containers in the store specification and updates the scheduled task job logic to use these new settings. The most important changes are grouped below:
Scheduled Task Container Support:
ScheduledTaskContainerfield of typeContainerMergeSpecto theStoreSpecstruct inapi/v1/store.go, allowing users to specify container overrides for scheduled tasks.Scheduled Task Job Logic:
ScheduledTaskJobfunction ininternal/cronjob/scheduled_task.goto merge theScheduledTaskContainersettings into the main container configuration, ensuring that scheduled task jobs use the correct container overrides.