Skip to content

fix: error during offline theme compilation#14543

Merged
Andrii Havryliuk (h1k3r) merged 3 commits intotrunkfrom
fix-error-on-offline-theme-compilation
Jan 28, 2026
Merged

fix: error during offline theme compilation#14543
Andrii Havryliuk (h1k3r) merged 3 commits intotrunkfrom
fix-error-on-offline-theme-compilation

Conversation

@h1k3r
Copy link
Copy Markdown
Contributor

1. Why is this change necessary?

When theme is compiled without database, and delayed invalidation is enabled, theme compiles, but user sees error message that may be confusing.

2. What does this change do, exactly?

Reduces severity of logged message to the warning mode.

3. Describe each step to reproduce the issue or behaviour.

4. Please link to the relevant issues (if any).

5. Checklist

  • I have written tests and verified that they fail without my change
  • I have updated developer-facing release notes if this change is relevant for external developers:
    • Add a short entry to RELEASE_INFO-6.<major>.md under “Upcoming” for informational changes, including the consequences of the change and how it affects external developers.
    • Add an UPGRADE section in UPGRADE-6.<next-major>.md for breaking changes (what/why/impact/how to adapt).
    • See the Documenting a Release Process for details.
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfilled them

@h1k3r Andrii Havryliuk (h1k3r) added component/core domain/framework Responsible for the framework-level code includes core, administration, storefront, and frontends labels Jan 26, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 26, 2026

Warnings
⚠️ The Pull Request doesn't contain any release info, if your changes are relevant for external developers please add an entry to the release info file, including the consequences of the change and how it affects external developers. For detailed infos please refer to the [release documentation guide](https://github.com/shopware/shopware/blob/trunk/delivery-process/documenting-a-release.md).

@explore-openapi
Copy link
Copy Markdown

explore-openapi bot commented Jan 26, 2026

OpenAPI Snapshot

Project: shopware/store-api

No changes detected

Your OpenAPI schema is identical to the base branch (trunk).

Links:
All Project Snapshots · Base Branch Snapshot

Project: shopware/admin-api

No changes detected

Your OpenAPI schema is identical to the base branch (trunk).

Links:
All Project Snapshots · Base Branch Snapshot

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 26, 2026

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.35%. Comparing base (4d25bbe) to head (1cd2631).
⚠️ Report is 2 commits behind head on trunk.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/Core/DevOps/Environment/EnvironmentHelper.php 0.00% 1 Missing ⚠️
src/Core/Framework/App/ActiveAppsLoader.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #14543      +/-   ##
==========================================
+ Coverage   55.34%   55.35%   +0.01%     
==========================================
  Files        2962     2962              
  Lines       91414    91415       +1     
==========================================
+ Hits        50594    50604      +10     
+ Misses      40820    40811       -9     
Flag Coverage Δ
phpunit-migration 92.23% <ø> (ø)
phpunit-unit 52.85% <71.42%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@h1k3r Andrii Havryliuk (h1k3r) added the skip-danger-phpstan-baseline Add this label to skip the danger check for the PHPStan baseline label Jan 26, 2026
@h1k3r Andrii Havryliuk (h1k3r) added this pull request to the merge queue Jan 28, 2026
Merged via the queue into trunk with commit 710788d Jan 28, 2026
67 checks passed
@h1k3r Andrii Havryliuk (h1k3r) deleted the fix-error-on-offline-theme-compilation branch January 28, 2026 12:55
@github-actions github-actions bot added this to the 6.7.8.0 milestone Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/core domain/framework Responsible for the framework-level code includes core, administration, storefront, and frontends milestone/6.7.8.0 skip-danger-phpstan-baseline Add this label to skip the danger check for the PHPStan baseline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compiling the storefront without a database

5 participants