Extract property-whitelist into constant for easier comprehension of relation#2121
Closed
Joshua Behrens (JoshuaBehrens) wants to merge 1 commit intoshopware:trunkfrom
Conversation
|
Hello, thank you for creating this pull request. Please use this issue to track the state of your pull request. |
Member
|
Thanks for your Contribution! |
Contributor
Author
|
Thank you for the merge 😍 💙 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
In the past it was not easy to understand what the property-whitelist does and where it comes from. Seeing the relation of the cms loader running first, changing the incoming request and the later feature subscriber using that data is not very easy to understand. This makes it easier.
2. What does this change do, exactly?
Introduces a constant and used it everywhere applicable.
3. Describe each step to reproduce the issue or behaviour.
4. Checklist