Skip to content

Extract property-whitelist into constant for easier comprehension of relation#2121

Closed
Joshua Behrens (JoshuaBehrens) wants to merge 1 commit intoshopware:trunkfrom
JoshuaBehrens:feature/extract-property-whitelist-into-constant
Closed

Extract property-whitelist into constant for easier comprehension of relation#2121
Joshua Behrens (JoshuaBehrens) wants to merge 1 commit intoshopware:trunkfrom
JoshuaBehrens:feature/extract-property-whitelist-into-constant

Conversation

@JoshuaBehrens
Copy link
Contributor

1. Why is this change necessary?

In the past it was not easy to understand what the property-whitelist does and where it comes from. Seeing the relation of the cms loader running first, changing the incoming request and the later feature subscriber using that data is not very easy to understand. This makes it easier.

2. What does this change do, exactly?

Introduces a constant and used it everywhere applicable.

3. Describe each step to reproduce the issue or behaviour.

  1. Try to understand how the filter limitation in the admin works.

4. Checklist

  • I have written tests and verified that they fail without my change
  • I have squashed any insignificant commits
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@shopwareBot
Copy link

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-17955

Please use this issue to track the state of your pull request.

@shyim
Copy link
Member

Thanks for your Contribution!

@JoshuaBehrens
Copy link
Contributor Author

Thank you for the merge 😍 💙

@JoshuaBehrens Joshua Behrens (JoshuaBehrens) deleted the feature/extract-property-whitelist-into-constant branch October 14, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants