Skip to content

fix: App url change strategies do not consider services#6426

Merged
Aydin Hassan (AydinHassan) merged 3 commits intotrunkfrom
fix/app-url-change-services
Jan 28, 2025
Merged

fix: App url change strategies do not consider services#6426
Aydin Hassan (AydinHassan) merged 3 commits intotrunkfrom
fix/app-url-change-services

Conversation

@AydinHassan
Copy link
Copy Markdown
Contributor

@AydinHassan Aydin Hassan (AydinHassan) commented Jan 24, 2025

1. Why is this change necessary?

App url change strategies do not consider services

2. What does this change do, exactly?

Change strategies to load apps from the database and fetch manifest via source resolver

3. Describe each step to reproduce the issue or behaviour.

Install a service, change url and try to fix using the strategies

@github-actions
Copy link
Copy Markdown

Warnings
⚠️ The Pull Request doesn't contain any changelog file

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 50.21%. Comparing base (218d6cb) to head (95be6e9).
Report is 9 commits behind head on trunk.

Files with missing lines Patch % Lines
...UrlChangeResolver/AbstractAppUrlChangeStrategy.php 0.00% 5 Missing ⚠️
...pUrlChangeResolver/MoveShopPermanentlyStrategy.php 0.00% 1 Missing ⚠️
...App/AppUrlChangeResolver/ReinstallAppsStrategy.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk    #6426      +/-   ##
==========================================
- Coverage   50.24%   50.21%   -0.03%     
==========================================
  Files        4798     4801       +3     
  Lines      163852   163950      +98     
  Branches     9175     9175              
==========================================
+ Hits        82323    82327       +4     
- Misses      78750    78842      +92     
- Partials     2779     2781       +2     
Flag Coverage Δ
jest-admin 59.27% <ø> (+0.01%) ⬆️
jest-storefront 67.28% <ø> (ø)
phpunit-migration 38.45% <ø> (ø)
phpunit-unit 41.87% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AydinHassan Aydin Hassan (AydinHassan) marked this pull request as ready for review January 27, 2025 11:55
@AydinHassan Aydin Hassan (AydinHassan) requested a review from a team January 27, 2025 11:55
@AydinHassan Aydin Hassan (AydinHassan) changed the title fix: App url change strategies do not consider services, just use the… fix: App url change strategies do not consider services Jan 27, 2025
@AydinHassan Aydin Hassan (AydinHassan) deleted the fix/app-url-change-services branch January 28, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants