Skip to content

docs: add getting started and code push sections#2

Merged
felangel merged 4 commits into
mainfrom
docs/getting-started-and-code-push
Apr 25, 2023
Merged

docs: add getting started and code push sections#2
felangel merged 4 commits into
mainfrom
docs/getting-started-and-code-push

Conversation

@felangel

Copy link
Copy Markdown
Contributor

Status

READY

Description

  • docs: add getting started and code push sections

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added the documentation Improvements or additions to documentation label Apr 24, 2023
@felangel felangel requested review from bryanoltman and eseidel April 24, 2023 21:56
@felangel felangel self-assigned this Apr 24, 2023
Comment thread docs/index.md
# Overview

Welcome to the Shorebird docs.
Welcome to Shorebird 👋

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will come back to this in a subsequent PR.

@eseidel eseidel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't read it all the way (yet). Is it staged somewhere we could see it that way?

Comment thread docs/code_push/_category_.json Outdated
Comment thread docs/code_push/build.md

# Build your Shorebird App

You can use `shorebird build` to build a release version of your app including code push:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release is generally the main flow, no?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah build is last in this section.

@felangel felangel closed this Apr 25, 2023
@felangel felangel reopened this Apr 25, 2023
@felangel

Copy link
Copy Markdown
Contributor Author

I didn't read it all the way (yet). Is it staged somewhere we could see it that way?

GitHub actions is down atm so the quickest way to see it would be to check out the branch and run it locally.

@eseidel eseidel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review this in detail. I think we should just land this and I will wordsmith and send you a PR. :)

@felangel felangel merged commit 91a9590 into main Apr 25, 2023
@felangel felangel deleted the docs/getting-started-and-code-push branch April 25, 2023 02:44
@tomarra tomarra mentioned this pull request Jul 2, 2026
3 tasks
tomarra added a commit that referenced this pull request Jul 2, 2026
* docs: use sentence case for headers

Per the marketing content guidelines, headers should use sentence
case, not Title Case. Fixes 169 headings across 44 files.

Left several categories of heading untouched, all confirmed by
testing directly against Vale rather than guessing:

- Compound product/brand names where per-word exception matching
  breaks down and partially-casing the phrase reads worse than the
  original: "Azure Key Vault", "GCP Cloud KMS", "App Store Connect",
  "Firebase Remote Config", "Launch Darkly", "Flutter Hot Reload".
- Three "Flutter vs. X" headings: Vale's capitalization rule flags
  any heading containing "vs"/"vs." regardless of surrounding case,
  a hardcoded quirk that isn't configurable via the exceptions list.
- Four "code push" FAQ headings (e.g. "Does code push require the
  internet to work?"): enabling the Vocab-driven proper-noun rule
  causes Vale's capitalization rule to also flag any lowercase vocab
  term (Shorebird/Flutter/Code Push) in a heading, even though sentence
  case itself has no violation here. These already get fixed by the
  proper-noun-capitalization PR; no separate edit needed here.
- Three sequential numbered headings ("1. The Status Enum", "2. The
  Single State Class", "3. The Events"): Vale's algorithm inexplicably
  passes #2 once lowercased but keeps flagging #1 and #3 with
  identical structure. Reverted all three to Title Case to keep the
  numbered list visually consistent rather than partially complying.

Also discovered and fixed real proper nouns that weren't yet
recognized by the Headings rule's exceptions list (Stripe, Fastfile,
BuildContext, RenderObject, Apple, 1Password, AOT, GuardSquare, LTS,
ExportOptions.plist, Skia, Impeller) and two headings using lowercase
"fastlane" where the tool name should be capitalized ("Using Fastlane
on CI/locally"). These exceptions need to land in the tooling PR
(#576) as well, or they'll show as false positives again once these
two PRs both merge.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* fix comments

* fix comments

---------

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants