Conversation
dpwe
approved these changes
Jan 31, 2025
Collaborator
dpwe
left a comment
dpwe
left a comment
There was a problem hiding this comment.
Looks great!
I think we should probably call the Synth class synth.PatchSynth() - it's not actually a base class for all synthesizers, although the voice rotation stuff probably should be a base class. What we currently call Synth is explicitly "a synthesizer constructed from voices that use the voices preset/stored patches mechanism".
I think in the future we'll have a VoicesSynth base-class that handles note-stealing, and PatchSynth will be a thin specialization of it, but that can come later.
I think the PCMSynth class that Douglas is kinda asking for will be a good future addition too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
douglas gave us good feedback about midi.py having all the Synth stuff in it was a bit confusing, so here's a first pass at separating out these. docs updated as well.