For SG-9540, upgrade httplib2 #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 17, 2019 08:31
houndci-bot
reviewed
Jan 21, 2019
added 2 commits
January 21, 2019 15:27
houndci-bot
reviewed
Jan 21, 2019
houndci-bot
reviewed
Jan 21, 2019
houndci-bot
reviewed
Jan 21, 2019
manneohrstrom
approved these changes
Jan 22, 2019
|
|
||
| You can see the [full history of the Python API on the documentation site](http://developer.shotgunsoftware.com/python-api/changelog.html). | ||
|
|
||
| ## Updating HTTPLib2 |
pboucher
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades httplib2 to the most recent version (0.12.0). It has been slightly modified so the library imports parts of itself via
from . import <something>instead offrom http2lib import something, as the library isn't part of thePYTHONPATH.The reasons for this are two-fold:
For the cacerts, we will have to revisit how we update the cacerts file so we don't end up with an out of date list in the future.
I also refactored the setUp code from the base test classes. Since these methods were essentially loading data from Shotgun in read-only, I've moved their initialization code from
setUptosetUpClass, which means these values will be read from Shotgun once for every class instead of once per test. The execution time dropped from 287 seconds to 165 seconds on my computer.