SG-13480: Fixed failed tests #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed failed tests caused by the auto-crlf on git on Windows - Fixed 'sudo_as_login' fails test: It looks like the server is returning a different error than the one the test expects. The error the server is returning seems correct for what's happening, So Will thinks that something changed SG-side and we need to update the test to match. It's looking for an error that says The user does not have permission to 'sudo': Instead it's seeing Cannot 'sudo' - unknown or retired user: Which, given that blah isn't a real user, makes sense
Pull Request Test Coverage Report for Build 1266
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1263
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing it by adding a .gitattributes file that force .pickle file to have Unix eols (LF)