Skip to content

SG-40994 Update deprecation warning message about end of compat with Py 3.7#424

Merged
julien-lang merged 9 commits intomasterfrom
ticket/SG-40994-update-py37-deprecation-warnings
Nov 25, 2025
Merged

SG-40994 Update deprecation warning message about end of compat with Py 3.7#424
julien-lang merged 9 commits intomasterfrom
ticket/SG-40994-update-py37-deprecation-warnings

Conversation

@julien-lang
Copy link
Copy Markdown
Member

@julien-lang julien-lang commented Nov 7, 2025

Related to shotgunsoftware/tk-core#1069

Follow up from #417

Add SHOTGUN_ALLOW_OLD_PYTHON variable.

@julien-lang julien-lang requested a review from Copilot November 7, 2025 18:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the deprecation warning message for Python versions older than 3.9 to provide clearer timeline information and updated version recommendations.

Key Changes:

  • Updated the compatibility removal timeline from "2026-01" to "end of March 2026"
  • Changed the recommended upgrade target from "Python 3.9 or a newer supported version" to "Python 3.11 or any other supported version"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread shotgun_api3/__init__.py
Copy link
Copy Markdown
Contributor

@carlos-villavicencio-adsk carlos-villavicencio-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread shotgun_api3/__init__.py Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Comment thread shotgun_api3/__init__.py Outdated
@charltk
Copy link
Copy Markdown

charltk commented Nov 14, 2025

Looks good to me

Copy link
Copy Markdown
Contributor

@mchesnay mchesnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions, but looks good overall

Comment thread docs/installation.rst Outdated
Comment thread docs/reference.rst Outdated
Comment thread docs/reference.rst Outdated
Comment thread shotgun_api3/__init__.py Outdated
Comment thread shotgun_api3/__init__.py Outdated
Co-authored-by: Martin Chesnay <104032692+mchesnay@users.noreply.github.com>
@julien-lang julien-lang merged commit a567589 into master Nov 25, 2025
23 checks passed
@julien-lang julien-lang deleted the ticket/SG-40994-update-py37-deprecation-warnings branch November 25, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants