#34265 add support for SHOTGUN_DISABLE_SSL_VALIDATION env variable

[kporangehat]

Setting the SHOTGUN_DISABLE_SSL_VALIDATION environment variable to 1 will set the NO_SSL_VALIDATION option.

[manneohrstrom]

With the above code, I would get the following logic in a bash shell:

export SHOTGUN_DISABLE_SSL_VALIDATION=1 --> validation will be disabled
export SHOTGUN_DISABLE_SSL_VALIDATION=0 --> validation will also be disabled
export SHOTGUN_DISABLE_SSL_VALIDATION   --> no effect

Is this perhaps confusing? If we did something like this:

if os.environ.get("SHOTGUN_DISABLE_SSL_VALIDATION", "0") != "0"

, export SHOTGUN_DISABLE_SSL_VALIDATION=0 would not trigger the disabled state, which i feel is more what I would expect. (The above could could probably be done more elegantly, and I haven't tested it on windows). Does that make sense?

Also, I think it would be nice if we could add unit tests if possible, since environment variables sometimes behave subtly different on different platforms. Also, is this documented anywhere? I did a quick check through the docs, but couldn't seem to find any mention of NO_SSL_VALIDATION. Apologies if I missed it!

[kporangehat]

Agreed. Pulled the release until it's fixed. ⚡