SG-35760 first phase python2 removing#10
Merged
eduardoChaucaGallegos merged 2 commits intomasterfrom Sep 6, 2024
Merged
Conversation
Contributor
eduardoChaucaGallegos
commented
Jul 4, 2024
eduardoChaucaGallegos
commented
- Six ensure function replaced.
eduardoChaucaGallegos
changed the title
julien-lang
reviewed
Jul 4, 2024
| import os | ||
| from sgtk.platform.qt import QtCore, QtGui | ||
| from tank_vendor import six | ||
| from tank_vendor import sgutils |
Member
There was a problem hiding this comment.
Does that requires a specific version of tk-core? If so, it needs to be set in info.yml - requires_core_version.
But can we have a transitional step instead? Something that could work with both old and new versions of tk-core?
eduardoChaucaGallegos
requested review from
carlos-villavicencio-adsk and
julien-lang
carlos-villavicencio-adsk
approved these changes
Jul 10, 2024
julien-lang
approved these changes
Jul 12, 2024
eduardoChaucaGallegos
deleted the
ticket/SG-35760-first-phase-pythn2-removing
branch
eduardoChaucaGallegos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.