SG-32814 Improve Experience for MoBU#104
Merged
julien-lang merged 2 commits intoJun 10, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR aims to improve the experience for MoBU by refining the engine startup error handling. Key changes include a more granular exception check before displaying an error message.
Comments suppressed due to low confidence (1)
app_specific/motionbuilder/startup/init_tank.py:51
- [nitpick] Consider adding parentheses around the individual conditions to improve clarity of the boolean logic in the if statement.
if not isinstance(e, tank.TankError) or not hasattr(e, "_tank_error_raised_already"):
carlos-villavicencio-adsk
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to shotgunsoftware/tk-motionbuilder#36